Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement to ncsim target #102

Merged
merged 3 commits into from
May 20, 2019
Merged

Enhancement to ncsim target #102

merged 3 commits into from
May 20, 2019

Conversation

Kuree
Copy link
Collaborator

@Kuree Kuree commented May 16, 2019 •
edited
Loading

  • Add switch to suppress warnings.
  • Add switch to dump VCD
  • Add parameter to specify the number of cycles

@Kuree Kuree requested a review from leonardt May 16, 2019 04:45
@coveralls
Copy link

coveralls commented May 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 906

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 76.513%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/system_verilog_target.py 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
fault/system_verilog_target.py 1 16.57%
Totals Coverage Status
Change from base Build 879: -0.4%
Covered Lines: 1365
Relevant Lines: 1784
💛 - Coveralls

@Kuree Kuree changed the title add number of cycles to ncsim Enhancement to ncsim target May 19, 2019
leonardt
leonardt approved these changes May 20, 2019
View reviewed changes
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leonardt leonardt merged commit ba0a381 into sv-file-io May 20, 2019
@leonardt leonardt deleted the add_num_cycle branch May 20, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kuree @coveralls @leonardt