Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve pytest and brew issues #249

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Resolve pytest and brew issues #249

merged 4 commits into from
Aug 3, 2020

Conversation

sgherbst
Copy link
Collaborator

@sgherbst sgherbst commented Aug 3, 2020

This small PR gets the BuildKite and GitHub Actions tests passing again by constraining pytest to use a version number less than 6.x.x.

While fixing that issue, I found a separate problem in the MacOS Test on GitHub Actions. gmp, mpfr, libmpcare now installed by default; gmp and libmpc are the latest version whereas mpfr was an older version. This appears to have caused an error when brew install was used. brew upgrade fixed the problem.

Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this.

@sgherbst sgherbst marked this pull request as ready for review August 3, 2020 20:11
@sgherbst sgherbst merged commit 15c5b82 into master Aug 3, 2020
@sgherbst sgherbst deleted the pytest_fix branch August 3, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants