Add var poke test for signed values #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out fault converts signed values in poke/expect to unsigned
values (see process_signed_values). This is because verilator uses
unsigned C types for the ports (even though in magma it may be an SInt).
I also updated the var test's interface to be more consistent by using
BitVector and SIntVector instead of m.Bits (since this is testing I
think it makes sense to use the hwtypes versus magma types). I had to
make a small change to make_value to support that (no conversion is
necessary since we're already using an appropriate BitVector type).
I remove the signed specific cdoe for the var poke since it's not needed
(since the poke value will be converted to unsigned by
process_signed_value, we should store it as unsigned, the same way that
verilator does it).
This is similar to how the system verilog test bench works (magma/coreir
does not generate the signed prefix for m.SInt types, so they are
treated as unsigned in the design and test benches, so we convert signed
python values to unsigned when generating code).