Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is instead of == for port equality #99

Merged
merged 1 commit into from
May 20, 2019
Merged

Use is instead of == for port equality #99

merged 1 commit into from
May 20, 2019

Conversation

leonardt
Copy link
Owner

== corresponds to instancing a mantle.EQ circuit for magma circuit ports. For the actions __eq__ method we want to check equality for testing purposes (e.g. compare a generated action sequence versus a manually crafted expected action sequence), so it should be using is instead of == to check object equality (versus just creating an EQ circuit).

@leonardt leonardt requested a review from rsetaluri May 15, 2019 17:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 848

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.822%

Totals Coverage Status
Change from base Build 840: 0.0%
Covered Lines: 1365
Relevant Lines: 1754

💛 - Coveralls

@leonardt leonardt merged commit fd70199 into master May 20, 2019
@leonardt leonardt deleted the patch-eq branch May 20, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants