Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds right associative ops #151

Merged
merged 6 commits into from
Oct 14, 2022
Merged

adds right associative ops #151

merged 6 commits into from
Oct 14, 2022

Conversation

rdaly525
Copy link
Collaborator

No description provided.

cdonovick
cdonovick approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@cdonovick cdonovick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me assuming you understand that you did not add right associative operators. Right associative means x op y op z := x op (y op z). You have added reflected operators.

@cdonovick
Copy link
Collaborator

@leonardt you do understand why CI is failing? It doesn't seem to be fp anymore.

@rdaly525
Copy link
Collaborator Author

z4r/python-coveralls#74 indicates a fix of installing 'coveralls' instead of 'python-coveralls'

@leonardt leonardt merged commit 4ae3470 into master Oct 14, 2022
@leonardt leonardt deleted the radd branch October 14, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdonovick cdonovick cdonovick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdaly525 @cdonovick @leonardt