Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change concat to match magma #50

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Change concat to match magma #50

merged 3 commits into from
Jun 12, 2019

Conversation

cdonovick
Copy link
Collaborator

@cdonovick cdonovick commented Jun 10, 2019 •
edited
Loading

resolves #45

@cdonovick
Copy link
Collaborator Author

@rdaly525 could you update lassen to use the new concat

@rdaly525
Copy link
Collaborator

lassen PR: StanfordAHA/lassen#119

@rdaly525 rdaly525 requested a review from leonardt June 11, 2019 20:03
leonardt
leonardt approved these changes Jun 12, 2019
View reviewed changes
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdaly525 rdaly525 merged commit d8d93af into master Jun 12, 2019
@rdaly525 rdaly525 deleted the concat branch June 12, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

semantics for Bitvector concat is opposite of magma concat
3 participants
@cdonovick @rdaly525 @leonardt