Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with overflow #52

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Fix issue with overflow #52

merged 1 commit into from
Jun 17, 2019

Conversation

cdonovick
Copy link
Collaborator

No description provided.

@cdonovick cdonovick requested a review from rdaly525 June 12, 2019 22:10
rdaly525
rdaly525 approved these changes Jun 12, 2019
View reviewed changes
Copy link
Collaborator

@rdaly525 rdaly525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rdaly525 rdaly525 mentioned this pull request Jun 12, 2019
Closed
@cdonovick
Copy link
Collaborator Author

@leonardt @rdaly525 can we get this merged? I am not sure if lassen's overflow will build correctly otherwise. Assuming magma doesn't rewrite Bit or Bit to Bit | Bit.

@leonardt
Copy link
Owner

Magma does not rewrite those operators

@leonardt leonardt merged commit 44cb8be into master Jun 17, 2019
@leonardt leonardt deleted the fix-ovf branch June 17, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdaly525 rdaly525 rdaly525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdonovick @leonardt @rdaly525