Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated constructors from BitVector #55

Merged
merged 5 commits into from
Jul 1, 2019
Merged

Remove deprecated constructors from BitVector #55

merged 5 commits into from
Jul 1, 2019

Conversation

cdonovick
Copy link
Collaborator

Also deprecates implicit size constructors.

@cdonovick cdonovick requested a review from leonardt June 27, 2019 20:40
leonardt
leonardt approved these changes Jun 28, 2019
View reviewed changes
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want to wait to merge/release this? We could do a major version number bump since this could be considered a "syntax" change.

@cdonovick
Copy link
Collaborator Author

I was thinking give it till monday cause I just sent out the warning email. Yeah it would make sense to bump to 1.1.0

@leonardt
Copy link
Owner

Sounds good to me

@cdonovick cdonovick merged commit 1262008 into master Jul 1, 2019
@cdonovick cdonovick deleted the no-old branch July 8, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdonovick @leonardt