Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap #16

Merged
merged 23 commits into from
Nov 8, 2018
Merged

Tap #16

merged 23 commits into from
Nov 8, 2018

Conversation

leonardt
Copy link
Owner

Adds JTAG TAP controller example in Verilog and Silica. Accompanied by necessary internal changes to push the example through.

This is a basic version that uses just one yield statement, now the plan is to iterate on the coroutine representation to make it more compact (e.g. using loop patterns where possible).

First, I'd like to evaluate the quality of the synthesis results on this basic version (in theory, it should be identical to the verilog).

Good job all!

@coveralls
Copy link

coveralls commented Oct 31, 2018

Pull Request Test Coverage Report for Build 329

  • 154 of 177 (87.01%) changed or added relevant lines in 12 files are covered.
  • 45 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.1%) to 68.48%

Changes Missing Coverage Covered Lines Changed/Added Lines %
silica/cfg/util.py 16 17 94.12%
silica/cfg/ssa.py 38 41 92.68%
silica/width.py 6 15 40.0%
silica/transformations/promote_widths.py 18 28 64.29%
Files with Coverage Reduction New Missed Lines %
silica/transformations/promote_widths.py 1 65.31%
silica/cfg/ssa.py 2 81.08%
silica/cfg/control_flow_graph.py 3 65.63%
silica/width.py 3 45.71%
silica/compile.py 3 74.35%
silica/transformations/desugar_for_loops.py 12 60.2%
silica/verilog.py 21 70.05%
Totals Coverage Status
Change from base Build 290: -0.1%
Covered Lines: 1662
Relevant Lines: 2427

💛 - Coveralls

@rdaly525
Copy link
Collaborator

My guess is that the verilog might be bad due to the giant mux chain from the NS logic

@leonardt leonardt merged commit 781d3ab into master Nov 8, 2018
@leonardt leonardt deleted the tap branch November 8, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants