Add support for inlining slice/index when just an ID #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardt
commented
Jul 23, 2020
| } | ||
| return Transformer::visit(std::move(node)); | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to do this here because Index doesn't have an Expression as it's value, but Slice has Expression for the type of value, so the visitor below works (ideally we should update Slice to be variant since we can't support general expressions for slices, but I'll leave that for a separate change set. once we do that, we'll need a similar implementation as this method.
rsetaluri
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for coreir inlining of mantle wires for slices.
Before, we blacklisted inlining of indices/slices because expressions like
(x + y)[0]are not valid. However, we can do this when we're just inlining a different identifier, so this augments the logic to not blacklist inlining for wires when they're being assigned by an identifier.