Add support for nd-vector #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardt
commented
Jul 30, 2020
tests/basic.cpp
Outdated
| dims.push_back(vAST::make_num("32")); | ||
| vAST::NDVector slice(vAST::make_id("x"), vAST::make_num("31"), | ||
| vAST::make_num("0"), std::move(dims)); | ||
| EXPECT_EQ(slice.toString(), "[31:0] x [8][32]"); |
There was a problem hiding this comment.
Don't remember exactly what the desired multi-dimensional array syntax is, but this is easy enough to change or make different options for.
There was a problem hiding this comment.
Think this way is good for now (believe that was the FB feedback as well)
rsetaluri
reviewed
Aug 4, 2020
rsetaluri
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code generating ndarrays
Also allows nested index nodes (for indexing the ndarrays)