Various small fixes and improvements (in preparation for some bigger changes) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote commits
New Captcha Behaviour and dependencies
"Fixes" the code to be compliant with PEP-8 standards. Includes removing unused variables (and imports), splitting up and replacing import statements (no more import *), fixing all lines to be no longer than 79 characters, minor syntax fixes, etc.
Added some labels and new types of files to ignore (related to chromedriver)
Catch and log all errors. Do a generic system exit.
When displayed with a smaller window size, the categories menu is ofen not visible, causing errors. This change catches the chromedriver error and deploys a workaround.
Will only display one warning if not found, not 2+
Switched cookiebanner code to use WebDriverWait instead of time.sleep. Now waits up to 3 seconds for the element to display (but can be less).
Added some more info, fixed some inaccuracies, typos, and spacing issues
Follows recommendation of the "undetected-chromedriver" and "selenium-wire" packages to make chromedriver less detectable. https://pypi.org/project/selenium-wire/#bot-detection
Changed text to be more relevant with current program flow
Reverts accidental changes to the book_reader_url that accidentally broke it.
Closed
|
Sorry for not looking at this sooner - real-life work has been quite hectic 😛 I'll give it a proper look this weekend! |
Iskendro
pushed a commit
to Iskendro/blinkist-scraper
that referenced
this pull request
Mar 20, 2022
Various small fixes and improvements (in preparation for some bigger changes)
Iskendro
pushed a commit
to Iskendro/blinkist-scraper
that referenced
this pull request
Mar 20, 2022
Various small fixes and improvements (in preparation for some bigger changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made many small changes to better follow code best practices.
Improves code quality, style, and performance. Fixes a few small bugs, and better catches some errors. Follows instructions from
selenium-wireto make chromedriver less detectable when usingundetected-chromedriver(if theselenium-wirepackage gets updated).