Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for python3.9 and 3.10 added #4

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Support for python3.9 and 3.10 added #4

merged 2 commits into from
Aug 30, 2023

Conversation

Chandrahas-B
Copy link
Contributor

#1

Currently only supporting Python 3.11 because that's all I've tested on, but supporting 3.9+ should be easy enough.

To do:

  • Set up testing matrix (tox or GitHub CI)
  • Fix any potential issues with Python 3.9 and 3.10

Chandrahas-B
Chandrahas-B commented Aug 27, 2023
View reviewed changes
Copy link
Contributor Author

@Chandrahas-B Chandrahas-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both 3.9 and 3.10 (in a conda environment)

.github/workflows/ci.yml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@leonoverweel
Copy link
Owner

Thanks for the PR @Chandrahas-B! Looks great, merging :)

@leonoverweel leonoverweel merged commit 14ae2f4 into leonoverweel:main Aug 30, 2023
3 checks passed
@leonoverweel leonoverweel mentioned this pull request Aug 30, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chandrahas-B @leonoverweel