Add suitable comments for GoDoc #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayushjn20 Build is failing with this. Can you fix it so we can merge? |
|
Got it. I opened a PR from my own fork, that's why the continuous-integration/travis-ci/pr is failing on snap login, but the continuous-integration/travis-ci/push build is passing. |
ayushjn20
requested review from
apoorvam,
agentmilindu,
charithccmc,
PratikDhanave,
rehrumesh and
rhperera
apoorvam
reviewed
Jun 28, 2019
| @@ -129,7 +134,8 @@ func process(configs *config.Configs, s *docker.Step, wg *sync.WaitGroup, args [ | |||
| } | |||
| } | |||
|
|
|||
| func passArgs(s *docker.Step, args *[]string) error { | |||
| // PassArgs replaces argument variables,of the form '`$d`', where d is a number, with dth argument. | |||
| func PassArgs(s *docker.Step, args *[]string) error { | |||
There was a problem hiding this comment.
Do you want to expose these functions outside package? Its used only within the package.
There was a problem hiding this comment.
Yeah! If dunner is going to be used as a library, then the method that passes the arguments to the commands should be exposed.
agentmilindu
approved these changes
Jun 30, 2019
rehrumesh
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76