Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Remove nodemailer and its related dependency #133

Closed
niloysikdar opened this issue Jan 14, 2023 · 1 comment · Fixed by #136
Closed

[Infra] Remove nodemailer and its related dependency #133

niloysikdar opened this issue Jan 14, 2023 · 1 comment · Fixed by #136
Assignees
@niloysikdar
Labels
documentation Improvements or additions to documentation enhancement New feature or request released

Comments

@niloysikdar
Copy link
Member

niloysikdar commented Jan 14, 2023 •
edited
Loading

Description:

Reference:

Currently, we're using nodemailer to use inside our validateEmail utility. Also right now, we have added only Mailtrap as the validation providers which can be found here.

Outcome:

  • But we have decided to remove the extra dependency of nodemailer, and document the validation process using different providers (for now, just Mailtrap) inside our Docusaurus documentation.

CC @agentmilindu
@niloysikdar niloysikdar added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 14, 2023
@niloysikdar niloysikdar self-assigned this Feb 19, 2023
niloysikdar added a commit that referenced this issue Feb 19, 2023
@niloysikdar
perf(validateemail): remove nodemailer and its related dependency
a4a2b20 
Remove nodemailer and whole validateEmail method from the package and add them to the docs

fix #133

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Feb 19, 2023
Merged
niloysikdar added a commit that referenced this issue Feb 24, 2023
@niloysikdar
perf(validateemail): remove nodemailer and its related dependency
7c4ea63 
Remove nodemailer and whole validateEmail method from the package and add them to the docs

fix #133

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
github-actions bot pushed a commit that referenced this issue Feb 24, 2023
@semantic-release-bot
chore(release): 1.15.6 [skip ci]
d87e6da 
## [1.15.6](v1.15.5...v1.15.6) (2023-02-24)

### Performance Improvements

* **validateemail:** remove nodemailer and its related dependency ([7c4ea63](7c4ea63)), closes [#133](#133)
@github-actions
Copy link

🎉 This PR is included in version 1.15.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
documentation Improvements or additions to documentation enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(validateemail): remove nodemailer and its related dependency leopardslab/react-email
1 participant
@niloysikdar