Fix file output parameter #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for creating this PR! Unfortunately, I already have implemented this functionality in a local branch. Also, I'm currently very busy with exams, so sorry for keeping you waiting. I'll try getting around to fixing up my changes and pushing them soon. When I do that, I will also add you as a co-author so you get credited for your help. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the argument for setting output directory, -o, doesn't do anything when set. This fix creates a path from the given string and amends it to the beginning of the output file. If an output directory is not specified then there is no change, but if one is specified then all outputs are written to the given directory. Accounts for trailing slash. Tested on Windows 10 and Ubuntu 20.04 LTS (WSL2).