Skip to content
This repository has been archived by the owner on Jun 18, 2023. It is now read-only.

updated v0.4.7 #38

Merged
merged 6 commits into from
Mar 5, 2020
Merged

updated v0.4.7 #38

merged 6 commits into from
Mar 5, 2020

Conversation

samapriya
Copy link
Contributor

  • Fixed issue with Werkzeug for now forcing to 0.16.1
  • Using postman client type to overcome use of robobrowser to create package cache

- Fixed issue with Werkzeug for now forcing to 0.16.1
- Using postman client type to overcome use of robobrowser to create package cache
@Rawleenc
Copy link

@samapriya When doing pip install pipwin in a venv and then replacing the installed pipwin.py file by yours, lxml causing problem when using pipwin. This problem is solved by using "html.parser" instead of "lxml".

@samapriya
Copy link
Contributor Author

hi @Barazok
Seems to be working with lxml at my end. My setup is
Windows 10
Python3.6
lxml 4.5.0

Can you try this in a virtual environment with python3

pip install git+https://github.com/samapriya/pipwin.git

please let me know of the specific errors you are getting

@Rawleenc
Copy link

It is working well if I install lxml specifically with pip install lxml but I'm just saying that if you use html.parser it's working well, exactly the same way as with lxml but without any dependencies.
From my point of view it's better to limit external dependencies as much as possible.

@samapriya
Copy link
Contributor Author

Makes sense @Barazok
Just removed lxml dependency and committed the changes for the pull request. Thanks for the input, lxml has performance benefits but I agree to add additional dependencies is not required here.

@Rawleenc
Copy link

No problem.
Make sure to remove lxml in requirements.txt and setup.py.
Otherwise, it seems perfects to me. Thanks for your fix. ;)

@samapriya
Copy link
Contributor Author

I knew I was missing something :) done

README.rst Outdated Show resolved Hide resolved
pipwin/pipwin.py Outdated Show resolved Hide resolved
pipwin/pipwin.py Outdated Show resolved Hide resolved
pipwin/pipwin.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
- removed robobrowser and wekzeug dependencies
- general improvements
@lepisma lepisma merged commit 75a0bd7 into lepisma:master Mar 5, 2020
samapriya added a commit to tyson-swetnam/porder that referenced this pull request Mar 5, 2020
- [Pull request](lepisma/pipwin#38) fixed issue with pipwin installation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants