Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageBox refactoring #504

Merged
merged 10 commits into from
Jan 25, 2023
Merged

MessageBox refactoring #504

merged 10 commits into from
Jan 25, 2023

Conversation

IvanDmitriev1
Copy link
Collaborator

@IvanDmitriev1 IvanDmitriev1 commented Jan 17, 2023 •
edited
Loading

Disabled ability on double click maximize.
Added support for ShowDialog.

Pull request type

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (with functional changes, api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • Window doesn't close automatically after any button press
  • Show method did not return which button was pressed
  • Visible in taskbar
  • You can change the size with the mouse
  • Does not change the size according to the size of the content

What is the new behavior?

-It's all fixed

@github-actions github-actions bot added the controls Changes to the appearance or logic of custom controls. label Jan 17, 2023
@IvanDmitriev1 IvanDmitriev1 marked this pull request as draft January 24, 2023 11:25
@IvanDmitriev1 IvanDmitriev1 marked this pull request as ready for review January 25, 2023 07:13
@pomianowski pomianowski merged commit 20f2916 into lepoco:development Jan 25, 2023
@IvanDmitriev1 IvanDmitriev1 deleted the MessageBox branch January 25, 2023 14:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees
No one assigned
Labels
controls Changes to the appearance or logic of custom controls.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanDmitriev1 @pomianowski