Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TitleBar refactoring #508

Merged
merged 8 commits into from
Jan 23, 2023
Merged

TitleBar refactoring #508

merged 8 commits into from
Jan 23, 2023

Conversation

IvanDmitriev1
Copy link
Collaborator

@IvanDmitriev1 IvanDmitriev1 commented Jan 23, 2023 •
edited
Loading

Fixes: #291

Pull request type

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the new behavior?

  • TitleBar and TitleBarButton respond to Windows messages
  • By double-clicking on the icon, you can close the window

@github-actions github-actions bot added the controls Changes to the appearance or logic of custom controls. label Jan 23, 2023
@pomianowski pomianowski self-assigned this Jan 23, 2023
@pomianowski pomianowski added styles Topic is related to styles navigation Changes to navigation related controls. labels Jan 23, 2023
@pomianowski pomianowski added this to the Base controls complete milestone Jan 23, 2023
pomianowski
pomianowski approved these changes Jan 23, 2023
View reviewed changes
src/Wpf.Ui/Controls/TitleBarButton.cs
@@ -0,0 +1,141 @@
using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license

src/Wpf.Ui/Extensions/UiElementExtensions.cs

namespace Wpf.Ui.Extensions;

public static class UiElementExtensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs for publicly visible class.

src/Wpf.Ui/Extensions/UiElementExtensions.cs
@@ -0,0 +1,33 @@
using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license

@pomianowski pomianowski merged commit 24a6f03 into lepoco:development Jan 23, 2023
@IvanDmitriev1 IvanDmitriev1 deleted the Snap-layout branch February 1, 2023 07:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees

@pomianowski pomianowski

Labels
controls Changes to the appearance or logic of custom controls. navigation Changes to navigation related controls. styles Topic is related to styles
Projects
WPF UI Board
Status: Done
Milestone
Base controls complete
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanDmitriev1 @pomianowski