Bugfix/550 tree view scroll #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
github_actions
pomianowski
requested changes
Mar 2, 2023
| @@ -38,12 +38,21 @@ | |||
| BorderThickness="{TemplateBinding BorderThickness}" | |||
| CornerRadius="4"> | |||
| <ScrollViewer | |||
| CanContentScroll="{TemplateBinding ScrollViewer.CanContentScroll}" | |||
| Name="_tv_scrollviewer_" | |||
There was a problem hiding this comment.
Weird name for XAML element. Something like ItemsPresenterScrollViewer or PART_ScrollViewer (if used by the class) would be better.
| <Setter | ||
| TargetName="_tv_scrollviewer_" | ||
| Property="CanContentScroll" | ||
| Value="true"/> |
There was a problem hiding this comment.
Please use capital True for XAML.
| @@ -38,12 +38,21 @@ | |||
| BorderThickness="{TemplateBinding BorderThickness}" | |||
| CornerRadius="4"> | |||
| <ScrollViewer | |||
| CanContentScroll="{TemplateBinding ScrollViewer.CanContentScroll}" | |||
| Name="_tv_scrollviewer_" | |||
| CanContentScroll="false" | |||
There was a problem hiding this comment.
Please use capital False for XAML.
github-actions
bot
removed
github_actions
pomianowski
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: 550
What is the new behavior?
Now TreeView is scrolling correctly when virtualization is disabled
Other information