Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winui3 typography guidance and Wpf.Ui.Gallery improvements #563

Merged

Conversation

IvanDmitriev1
Copy link
Collaborator

@IvanDmitriev1 IvanDmitriev1 commented Mar 18, 2023

Started using Winui3 typography guidance for TextBlock.

Added TextBlock typography styles.
Added custom TextBlock with FontTypography property and Appearance property.
Added a Typography page in Wpf.Ui.Gallery.
Implemented IsTextSelectionEnabled in TextBox and RichTextBox.
Added DynamicScrollViewer to the NavigationViewContentPresenter by default.
Fixed TextBox icons position

Pull request type

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles labels Mar 18, 2023
@IvanDmitriev1
Copy link
Collaborator Author

IvanDmitriev1 commented Mar 18, 2023

@pomianowski By the way CardAction does not know how to decrease.
This is a problem with VirtualizingWrapPanel.
image

@IvanDmitriev1 IvanDmitriev1 changed the title Winui3 typography guidance Winui3 typography guidance and Wpf.Ui.Gallery improvements Mar 18, 2023
@cla-bot
Copy link

cla-bot bot commented Apr 24, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Apr 24, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@IvanDmitriev1
Copy link
Collaborator Author

@pomianowski what does it mean ?

@cla-bot
Copy link

cla-bot bot commented May 4, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented May 4, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@IvanDmitriev1
Copy link
Collaborator Author

@pomianowski Hi, review this pull request please.

@cla-bot
Copy link

cla-bot bot commented May 12, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Jun 11, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@pomianowski
Copy link
Member

Hey @IvanDmitriev1, thanks for more ideas and improvements in WPF UI. Some controls like Snackbar need improvement, but we can fine-tune it in the development branch.

@pomianowski pomianowski merged commit 807da9c into lepoco:development Jun 11, 2023
@IvanDmitriev1 IvanDmitriev1 deleted the Winui3-typograpy-guidance branch June 12, 2023 02:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
controls Changes to the appearance or logic of custom controls. styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants