Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update watcher let the auto update theme can be canceled #653

Merged
merged 3 commits into from
Jun 10, 2023

Conversation

chzuka
Copy link

@chzuka chzuka commented Jun 3, 2023

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • There is no method to cancel a watch in the watcher class.
  • It is not possible to modify the background style independently without modifying the overall theme.
  • The background color of the listviewitem is too light.

Issue Number: N/A

What is the new behavior?

  • Added the unwatch method for canceling the watch.
  • Deleted the judgment of whether the themetype is equal.
  • Changed the background color of the listviewitem.

Other information

@cla-bot
Copy link

cla-bot bot commented Jun 3, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 月怜.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@chzuka chzuka marked this pull request as ready for review June 3, 2023 08:59
@chzuka chzuka requested a review from pomianowski as a code owner June 3, 2023 08:59
@pomianowski pomianowski merged commit 2507de9 into lepoco:development Jun 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants