Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .clabot to fix invalid JSON from trailing comma #768

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

syntax-tm
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Currently the clabot errors out parsing the JSON (ERROR The .clabot file is not valid JSON).

2023-09-21T07:05:48.685Z INFO Checking CLAs for pull request https://api.github.com/repos/lepoco/wpfui/pulls/767
2023-09-21T07:05:48.685Z INFO Bot installed as an integration, obtaining installation token
2023-09-21T07:05:48.687Z INFO API Request https://api.github.com/app/installations/33815071/access_tokens
2023-09-21T07:05:48.760Z INFO Obtaining the list of commits for the pull request
2023-09-21T07:05:48.760Z INFO API Request https://api.github.com/repos/lepoco/wpfui/pulls/767/commits
2023-09-21T07:05:48.918Z INFO Total Commits: 1, checking CLA status for committers
2023-09-21T07:05:48.918Z INFO Attempting to obtain organisation level .clabot file URL
2023-09-21T07:05:48.918Z INFO API Request https://api.github.com/repos/lepoco/clabot-config/contents/.clabot
2023-09-21T07:05:48.999Z INFO Organisation configuration not found, resolving .clabot URL at project level
2023-09-21T07:05:48.999Z INFO API Request https://api.github.com/repos/lepoco/wpfui/contents/.clabot
2023-09-21T07:05:49.139Z INFO Obtaining .clabot configuration file from https://raw.githubusercontent.com/lepoco/wpfui/main/.clabot
2023-09-21T07:05:49.139Z INFO API Request https://raw.githubusercontent.com/lepoco/wpfui/main/.clabot
2023-09-21T07:05:49.367Z ERROR The .clabot file is not valid JSON
2023-09-21T07:05:49.367Z INFO API Request https://api.github.com/repos/lepoco/wpfui/statuses/771c692828a7d8387a040cbe0fcd814a350c997d
2023-09-21T07:05:49.727Z ERROR Error: The .clabot file is not valid JSON

Issue Number: N/A

What is the new behavior?

The file should be valid JSON now so hopefully the clabot quits complaining about it.

Other information

I realize this PR is for main, but this is intentional because the .clabot file used by the bot is the one on main.

@pomianowski pomianowski merged commit 3689074 into lepoco:main Sep 23, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants