Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clipping of menu items when using Navigation LeftFluent #773

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

jdrames
Copy link
Contributor

@jdrames jdrames commented Sep 27, 2023

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When using the LeftFluent navigation feature the text below the icons clip after selecting a menu item and then selecting another menu item. Letters that fall below the baseline don't appear correctly. Example letters: g, j, p, q, y. This can be seen by running the examples with navigation set to LeftFluent and then click on "Settings" and then back to Home or Data. The "g" in settings will now be clipped.

Issue Number: N/A

What is the new behavior?

  • the icon animation will process based on the FluentNavIconSize to match the icons size
  • no letters are clipped after the animation

Other information

Before

MenuBefore

After

MenuAfter

@cla-bot
Copy link

cla-bot bot commented Sep 27, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jdrames on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@jdrames jdrames changed the base branch from main to development September 30, 2023 05:05
@jdrames
Copy link
Contributor Author

jdrames commented Oct 1, 2023

@pomianowski The auto response from the cla-bot makes reference to signing a CLA. But there is no contact or additional information on this. Is there anything you need me to do for that?

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2023
@pomianowski pomianowski merged commit e67fe1e into lepoco:development Oct 9, 2023
3 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants