Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar fixes #873

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Dec 11, 2023

Updated the (Dynamic)ScrollBar default style to be more inline with WinUI addressing: #872

  • Added on hover background color (couldn't use InAppAcrylicDefaultBrush like in WinUI, but used the replacement color we also use for e.g. Flyout)
  • Decreased scrollbar thumb width based on WinUI spec
  • Decreased icon fontsize so it's centered and inline with WinUI spec

Before:
image

After:
image

ScrollBar now overlaps content, addressing: #871

  • Tweaked the default ScrollViewer style so it overlaps its content
  • Set a default style for PassiveScrollViewer so it uses the ScrollViewer style as well (as ListView uses PassiveScrollViewer)
    Before:
    image

After:
image

@niels9001
Copy link
Collaborator Author

@pomianowski In case this PR gets approved, would you mind creating a Preview.13 :)?

@pomianowski pomianowski merged commit 54a4d52 into lepoco:development Dec 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants