Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC - Add MonthDay column #111

Closed
leppott opened this issue Jan 27, 2021 · 5 comments
Closed

QC - Add MonthDay column #111

leppott opened this issue Jan 27, 2021 · 5 comments

Comments

@leppott
Copy link
Owner

leppott commented Jan 27, 2021

Is your feature request related to a problem? Please describe.
Add one new column to the QC csv file – a MonthDay text field as shown below. It needs to be a text field and have 2-digits for both month and day (e.g., 01/04 instead of 1/4), otherwise it won’t sort properly. This column serves as our left hand column in the pivot table. Right now we are asking users to create that field. It’d be a nice step to skip if possible

Describe the solution you'd like
During the QC step when add Month, Day, and Year columns add MonthDay.

Describe alternatives you've considered
Can add in Excel after the fact from the Month and Day columns but nicer to have it already added.

Additional context
image

@leppott
Copy link
Owner Author

leppott commented Jan 27, 2021

  1. Add to QC (regular and File versions).
  2. Combine with date format from config.
  3. Add column name and any other info to the config file.
  4. Update the config file in its various locations in the package (e.g., Shiny).

@leppott
Copy link
Owner Author

leppott commented Jan 27, 2021

MonthDay already exists in the config file.

ContData.env$myName.MoDa <- "MonthDay"

It is used in the stats operation.

Do not use a delimiter so always sorts correctly (as a number or character).

Text Editor (Notepad++)
image

Excel will drop the leading zeros and if thinks it is a date will add the current year. Since the file is a CSV cannot save the class (number vs. text vs. date).

Excel
image

@leppott leppott pinned this issue Jan 27, 2021
@leppott
Copy link
Owner Author

leppott commented Jan 27, 2021

Don't need to modify config file only the two QC scripts.

@leppott
Copy link
Owner Author

leppott commented Jan 27, 2021

Added.

Excel
image

Text Editor (Notepad++)
image

@leppott
Copy link
Owner Author

leppott commented Jan 27, 2021

Stats procedure is ok as it generates its own MonthDay. However, no stats are generated on MonthDay. Could be a future update.

leppott added a commit that referenced this issue Jan 27, 2021
* feature: Begin updates to add comparison of deployment periods, Issue #108
    + Add helper functions for rquery.t.test()
* feature: Add MonthDay to data during QC operation, Issue #111
* style: Trim some lines to 80 characters
    + fun.Stats.R
@leppott leppott closed this as completed Jan 27, 2021
@leppott leppott unpinned this issue Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant