example/counter_isomorphic Removed console warning. #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning is seen in the browsers console window. ``` counter_isomorphic.js:1068 At src/counters.rs:138:17, you are reading a resource in `hydrate` mode outside a <Suspense/> or <Transition/>. This can cause hydration mismatch errors and loses out on a significant performance optimization. To fix this issue, you can either: 1. Wrap the place where you read the resource in a <Suspense/> or <Transition/> component, or 2. Switch to using create_local_resource(), which will wait to load the resource until the app is hydrated on the client side. (This will have worse performance in most cases.) ``` Two derived signals "value" and "error_msg" need to be wrapped in a <Suspense> block. "value" falls back to just the initial text. "error" uses the default fallback.
|
In terms of review... I am constantly dipping in and out of the these examples... so I want them to be as close to a golden reference as possible if you want a different solution.. say involving Transition and create_local_resource |
|
Hi Martin! This change looks good, thanks for updating the example |
gbj
pushed a commit
that referenced
this pull request
Feb 8, 2024
This warning is seen in the browsers console window. ``` counter_isomorphic.js:1068 At src/counters.rs:138:17, you are reading a resource in `hydrate` mode outside a <Suspense/> or <Transition/>. This can cause hydration mismatch errors and loses out on a significant performance optimization. To fix this issue, you can either: 1. Wrap the place where you read the resource in a <Suspense/> or <Transition/> component, or 2. Switch to using create_local_resource(), which will wait to load the resource until the app is hydrated on the client side. (This will have worse performance in most cases.) ``` Two derived signals "value" and "error_msg" need to be wrapped in a <Suspense> block. "value" falls back to just the initial text. "error" uses the default fallback.
gbj
added a commit
that referenced
this pull request
Feb 9, 2024
videobitva
pushed a commit
to videobitva/leptos
that referenced
this pull request
Feb 17, 2024
This warning is seen in the browsers console window. ``` counter_isomorphic.js:1068 At src/counters.rs:138:17, you are reading a resource in `hydrate` mode outside a <Suspense/> or <Transition/>. This can cause hydration mismatch errors and loses out on a significant performance optimization. To fix this issue, you can either: 1. Wrap the place where you read the resource in a <Suspense/> or <Transition/> component, or 2. Switch to using create_local_resource(), which will wait to load the resource until the app is hydrated on the client side. (This will have worse performance in most cases.) ``` Two derived signals "value" and "error_msg" need to be wrapped in a <Suspense> block. "value" falls back to just the initial text. "error" uses the default fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning is seen in the browsers console window.
Two derived signals "value" and "error_msg" need to be wrapped in a Suspense block.
"value" falls back to just the initial text.
"error" uses the default fallback.