Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): address clippy issue #2278

Merged
merged 5 commits into from
Feb 9, 2024
Merged

fix(ci): address clippy issue #2278

merged 5 commits into from
Feb 9, 2024

Conversation

agilarity
Copy link
Contributor

@agilarity agilarity commented Feb 8, 2024

Addresses #2272

Changes

  • Pin nightly to a version that resolves the clippy issue.
  • Do not lint the dependencies of example crates

Notes

  • I have not found a way to skip dependency linting with cargo hack
  • Pinning nightly also suports the cargo-semver-checks Rust version recommendation.

Unsuccessful Checks

  • CI / CI (leptos) - Cancelled

  • CI / CI (leptos_reactive) - Cancelled

  • CI / CI (server_fn) - No ci output this time. Ran out of space in the previous run.

  • CI Examples / CI (examples/counter_isomorphic) - Compile Error

  • CI Examples / CI (examples/server_fns_axum) - Compile Error

  • CI Examples / CI (examples/todo_app_sqlite_axum) - Internal Error in server_fn

Feature: Delete Todo
  Scenario: Should not see the deleted todo
    > Given I see the app
   ✔> Given I see the app
      Given I add a todo as Buy Yogurt
thread '<unnamed>' panicked at /home/joseph/gh/leptos/server_fn/src/request/mod.rs:128:9:
internal error: entered unreachable code
  • CI Examples / CI (examples/todo_app_sqlite_csr) - Internal Error in server_fn
Feature: Delete Todo
  Scenario: Should not see the deleted todo
   ✔> Given I see the app
      Given I add a todo as Buy Yogurt
thread '<unnamed>' panicked at /home/joseph/gh/leptos/server_fn/src/request/mod.rs:128:9:
internal error: entered unreachable code

@agilarity agilarity marked this pull request as ready for review February 8, 2024 19:55
@gbj
Copy link
Collaborator

gbj commented Feb 9, 2024

Okay, thank you very much! This gets things back into a sane place, and I can work to address the unsuccessful checks you list.

@gbj gbj merged commit 65b7603 into leptos-rs:main Feb 9, 2024
52 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants