ci(examples): configure leptos examples to build with cargo-leptos when possible #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbj
reviewed
Feb 13, 2024
| @@ -117,13 +131,14 @@ function print_footer { | |||
| c="${BOLD}${YELLOW}C${RESET} = Cucumber Test Runner" | |||
| d="${BOLD}${YELLOW}F${RESET} = Fantoccini WebDriver" | |||
| l="${BOLD}${YELLOW}L${RESET} = Cargo Leptos" | |||
| m="${BOLD}${RED}M${RESET} = Cargo Leptos Medata Only (${ITALIC}ci is not configured to build with cargo-leptos${RESET})" | |||
There was a problem hiding this comment.
Small thing but I think Medata is probably a typo from Metadata here?
There was a problem hiding this comment.
Could you please commit these changes with the typo?
I will push another PR with some doc improvements.
|
Good catch, that is a typo.
I will submit a PR for it.
…On Mon, Feb 12, 2024 at 7:34 PM Greg Johnston ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks! One typo I saw, otherwise LGTM.
------------------------------
In examples/cargo-make/scripts/web-report.sh
<#2294 (comment)>:
> @@ -117,13 +131,14 @@ function print_footer {
c="${BOLD}${YELLOW}C${RESET} = Cucumber Test Runner"
d="${BOLD}${YELLOW}F${RESET} = Fantoccini WebDriver"
l="${BOLD}${YELLOW}L${RESET} = Cargo Leptos"
+ m="${BOLD}${RED}M${RESET} = Cargo Leptos Medata Only (${ITALIC}ci is not configured to build with cargo-leptos${RESET})"
Small thing but I think Medata is probably a typo from Metadata here?
—
Reply to this email directly, view it on GitHub
<#2294 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWF4QNEIQWV4TVQ5JVSQL3YTKYI3AVCNFSM6AAAAABDD3DJFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZWGYZDSMJSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2293
Changes
cargo make test-reportnow shows leptos crates that are not configured to build withcargo-leptoscileptos configuration for hackernews_islands_axum exampleNotes
cargo-leptos. It uses a custom build.