Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when tabs have similar names #7

Open
BernCarney opened this issue Sep 18, 2017 · 5 comments
Open

Bug when tabs have similar names #7

BernCarney opened this issue Sep 18, 2017 · 5 comments

Comments

@BernCarney
Copy link

When using buttons and having them link to a tab that shares a similar name with another, it will open both. My test case was opening Plex (in a new tab) and when it would open it, it would open PlexPy (in an iFrame). Change the PlexPy tab to "Stats" fixed it so you may want to look into stricter word matching logic.

For reference, my tabs were named Plex & PlexPy when I was having the issue. Plex & Stats when it works fine.

@leram84
Copy link
Owner

leram84 commented Sep 18, 2017

yeah, its an old bug, but unfortunately the html is not auto updating. To fix it you have to either grab the new html from the repo and update manually, or remove the caret from the script like so:
window.parent.$("li[name^='"+$(this).attr('tab')+"']").click();
should be replaced with:
window.parent.$("li[name='"+$(this).attr('tab')+"']").click();

All that being said, i should warn you that some very big changes are being pushed to organizr in the next 48 hours that will make a lot of this obsolete. I mean, nothing will change if you don't want it to, but there are some big improvements coming :)

@BernCarney
Copy link
Author

Sounds good to me! Any plans to add font customization in the future through the custom.css block or do you think this will always be handled by Organizr?

Sidenote, are the organizr updates going to be to realease or dev branch?

@leram84
Copy link
Owner

leram84 commented Sep 18, 2017

its in dev right now, but will prob be a little while longer till it all gets pushed to master. And i wouldn't try using any of the new layer cake stuff in dev atm. Cause is working on the new chat integration atm, and then we will go back and finish this theme stuff.

As for fonts. My goal with cake proper was to provide stock color theming tool, so the only font i adjusted was the css box itself (so i could display some sweet hacker art :) lol) but I have a very massive new thing that will def play w a few fonts here and there. What exactly are you trying to do anyway? anything is possible, just let me know what you want, and i can most likely wrap it up into an addon for you.

@BernCarney
Copy link
Author

BernCarney commented Sep 18, 2017 via email

@leram84
Copy link
Owner

leram84 commented Nov 16, 2017

hey, forgot to swing back around to this... i was obviously putting you off before cause at the time i was finishing up w blur lol. So does that work for you? or do you still prefer to stick w the default layercake themes, and still want the font pack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants