-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions issue with caching? #61
Comments
I believe there is a problem with the hash key. From the CICD log, we see that the key is |
https://github.com/actions/setup-python#caching-packages-dependencies
we don't commit the poetry.lock file so that might be it. we can either change the CI script to check for a changed pyproject.toml, or commit the lockfile. I didn't commit the lockfile at first because I thought it wouldn't matter, but I have no strong opinion about it. |
Yeah, I think @ckp95 is right. From poetry docs... I think apy falls in the application bucket, so I'd vote for committing the lock file. |
Yes, that sounds correct. I'm pushing the lockfile now, I think it makes sense for applications to have the lockfile as part of the repo. |
The relevant pipeline after adding the lock file: https://github.com/lervag/apy/actions/runs/5197352890. |
I believe it is safe to close this issue. |
After #59 was merged the GitHub actions step fails due to missing dependency of
mypy
:I believe this is because of this part:
apy/.github/workflows/ci.yaml
Lines 21 to 29 in 2aae673
But I'm not sure exactly what's wrong. I hope @ckp95 or @denismaciel would be able to help me here?
The text was updated successfully, but these errors were encountered: