Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows generic viewer opening #2309

Merged
merged 2 commits into from
Jan 28, 2022
Merged

fix windows generic viewer opening #2309

merged 2 commits into from
Jan 28, 2022

Conversation

habamax
Copy link
Contributor

@habamax habamax commented Jan 28, 2022

Fixes #2305

@habamax
Copy link
Contributor Author

habamax commented Jan 28, 2022

With this PR, default windows PDF viewer is properly used/opened when no SumatraPDF or muPDF is available on path.

@habamax
Copy link
Contributor Author

habamax commented Jan 28, 2022

The result cmd being called is:

  viewer: General
    job: 
      pid: 9220
      cmd: start "" "C:\Users\maksim.kim\docs\customers\xxx/json_msg/json_msg.pdf"

@lervag
Copy link
Owner

lervag commented Jan 28, 2022

Nice, thanks!

lervag added a commit that referenced this pull request Jan 28, 2022
@lervag
doc: update viewer default on windows
c246650 
refer: #2309
@lervag lervag merged commit 970aeba into lervag:master Jan 28, 2022
@habamax habamax deleted the patch-1 branch January 28, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VimtexCompile and VimtexView shows cmd.exe
2 participants
@habamax @lervag