Add integration tests w/ benchmarks #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `test` folder/sub-project created
- dart 2.2.2 requirement removed in order to be fully compatible with the parent
- localstorage parent dependency added to test drive
- clarity improved
- cleaner `assertTest` and `tputTest` widgets
- isolate flutter drive instrumentation from test app - move integration tests to their own file
- clear text indicators before running tests
- assert test added to verify basic functioning of the localstorage "Item" methods, namely: `deleteItem`, `getItem` and `setItem`
- 200 simultaneous runs to validate parallel read/writes
This reverts commit 8172603.
- `running` status should not force polling to break
- Integration tests added
- preserve upstream constraints
Closed
|
WOW 🤯 |
lesnitsky
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: covers issue #1
expected benefits: additional robustness, peace of mind on new releases and capability to measure performance easily
p.s. the base project structure has been fully respected and left alone, with the exception of the proposed removal of pubspec.lock according to What not to commit