Add temperature extrapolation #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
That's a very good change. Amazing work.
I don't have any comments. Good work, seriously good work :). that was a much needed feature :)
@hepap it will be interesting to see if this changes the results for the Marangoni case. It should not.
11 tasks
blaisb
pushed a commit
that referenced
this pull request
Sep 24, 2024
Description A bug in the VOF auxiliary physics was discovered when rerunning the gravity wave example. In the PR #994, BDF extrapolation of the velocity vector field in the VOF auxiliary physic was moved to the scratch data. However, the implementation was bypassed by an "if" condition. Solution This bug is fixed with this PR, and an application test was added to ensure that the feature remains intact with future implementations. Testing The new application test: applications_tests/lethe-fluid/vof-velocity-extrapolation.prm
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description This PR adds the extrapolation in time of temperature and temperature gradient value for source terms in the Navier-Stokes equations requiring them (Marangoni and evaporation recoil force terms). How Has This Been Tested? All tests have passed Comment Velocity extrapolation has been moved to include/solvers/vof_scratch_data.h. Solution extrapolations are now located in ScratchData to avoid constraint on assemblers order. Former-commit-id: 6dc4461
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description A bug in the VOF auxiliary physics was discovered when rerunning the gravity wave example. In the PR chaos-polymtl#994, BDF extrapolation of the velocity vector field in the VOF auxiliary physic was moved to the scratch data. However, the implementation was bypassed by an "if" condition. Solution This bug is fixed with this PR, and an application test was added to ensure that the feature remains intact with future implementations. Testing The new application test: applications_tests/lethe-fluid/vof-velocity-extrapolation.prm Former-commit-id: 202fb53
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description This PR adds the extrapolation in time of temperature and temperature gradient value for source terms in the Navier-Stokes equations requiring them (Marangoni and evaporation recoil force terms). How Has This Been Tested? All tests have passed Comment Velocity extrapolation has been moved to include/solvers/vof_scratch_data.h. Solution extrapolations are now located in ScratchData to avoid constraint on assemblers order. Former-commit-id: 6dc4461
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description A bug in the VOF auxiliary physics was discovered when rerunning the gravity wave example. In the PR #994, BDF extrapolation of the velocity vector field in the VOF auxiliary physic was moved to the scratch data. However, the implementation was bypassed by an "if" condition. Solution This bug is fixed with this PR, and an application test was added to ensure that the feature remains intact with future implementations. Testing The new application test: applications_tests/lethe-fluid/vof-velocity-extrapolation.prm Former-commit-id: 202fb53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Comment
include/solvers/vof_scratch_data.h. Solution extrapolations are now located inScratchDatato avoid constraint on assemblers order.