Ultrasonic Plugin _P013_HCSR04.ino broken with last commit of plugin

[lhurt]

I use a self compiled version.

Commit dcf8e86 (Jun. 9th) broke plugin _P013_HCSR04.ino

Build with tag mega-20180606

_ works and shows valid values like "ULTRASONIC : Distance: 167.00".
Build with tag mega-20180611 doesn't work and shows "ULTRASONIC : TaskNr: 2 Distance: No reading!".

Expected behavior

The values should be retrieved again.

Actual behavior

No values are retrieved making the sensor useless.

Steps to reproduce

1. Build firmware with tag mega-20180611 or later
2. See log output

System configuration

Hardware: H801 (ESP 8266)

Log of working version (mega-20180606)

Log of defective version (mega-20180611)

[DittelHome]

Same here ....

[lhurt]

Is it so hard to fix this? I use this pretty heavily and I am stuck with an old version.

[TD-er]

I will revert it to an older version and do fix it later.
I wanted to test it myself, with a test setup, but I have been busy lately with other issues and the last 2 days trying to figure out why MQTTimporter crashes (hard).

[lhurt]

I will revert it to an older version and do fix it later.
I wanted to test it myself, with a test setup, but I have been busy lately with other issues and the last 2 days trying to figure out why MQTTimporter crashes (hard).

Thanks for the quick reply.

[JojoS62]

its also the same issue: #1575
I've tried to fix it, please check my comments in that issue.

[JojoS62]

ok, I think I found the reason: the module is killing itself. There is a temporary oject created and inserted into a std::map. But the object is deleted on leaving the PLUGIN_INIT:

INIT : Booting version:  (ESP82xx Core 2_4_2, NONOS SDK 2.2.1(cfd48f3), LWIP: 2.0.3)
100 : INIT : Cold Boot - Restart Reason: External System
102 : FS   : Mounting...
126 : FS   : Mount successful, used 76304 bytes of 957314
151 : CRC  : No program memory checksum found. Check output of crc2.py
179 : CRC  : SecuritySettings CRC   ...OK 
272 : INIT : Free RAM:27376
273 : INIT : I2C
273 : INIT : SPI not enabled
277 : constructor P_013_sensordef
4278 : delete P_013_sensordef
4279 : ULTRASONIC : TaskNr: 1 TrigPin: 12 IRQ_Pin: 15 max dist cm: 150 max echo: 8607 nr_tasks: 1

so the constructor is called and after that the destructor. A copy of the struct is still in the map but pointing to an deleted NewPingESP8266 object. That caused also firmware reboots.

[TD-er]

That sounds plausible.
I will have to look at the code to see why.

[JojoS62]

here is the construction of a temporay object:

ESPEasy/src/_P013_HCSR04.ino

Line 110 in 30f5c5c

P_013_sensordefs[event->TaskIndex] =

I have uncommented the delete call in

ESPEasy/src/_P013_HCSR04.ino

Line 24 in 30f5c5c

delete sonar;

, then it works.
Maybe it is better to call delete in the PLUGIN_EXIT before the erase. Or not using a temporary object for inserting in the map.

[JojoS62]

this will fix it in PLUGIN_INIT:

        P_013_sensordef *newSensordef = new P_013_sensordef(Plugin_013_TRIG_Pin, Plugin_013_IRQ_Pin, max_cm_distance);
        P_013_sensordefs[event->TaskIndex] = *newSensordef;

in PLUGIN_EXIT, the erase is called and this will call the destructor, so memory will be cleaned correctly.

I've created a PR for this fix.

[TD-er]

Fixed by #1809