Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React native] [Teams] Members counter is not updated when user joins/leaves team #301

Closed
Dasha1990 opened this issue Jun 28, 2018 · 5 comments

Comments

@Dasha1990
Copy link
Collaborator

Dasha1990 commented Jun 28, 2018

Device: Samsung S4 note 6.0.1, iPhone 6 11.4

Steps to reproduce:

  1. login to the app
  2. Join any team
  3. Check response
    http://52.143.138.160:50000/api/v1/me/team is sent
    with team id
    {
    "team": "3b61c81a-2b8e-11e8-b467-0ed5f89f718r"
    }
    and team entity in response is:
    "teamInfo": {
    "name": "GSMA",
    "teamDescription": "Are you an employee or friend of GSMA. Join this team and help to make the change towards a cleaner and healthier world.",
    "image": "https://ucarecdn.com/82023a51-d50a-4f2f-aa0f-7e3a938de06b/Blueish.png",
    "nationalTeam": true,
    "createdAt": "2018-06-27T13:38:11.882Z",
    "id": "3b61c81a-2b8e-11e8-b467-0ed5f89f718r",
    "members": 0,
    "trashpoints": 0,
    "lastTrashpoints": [],
    "groupCount": {}
    }

Actual result: team is returned in users profile as his team but member counter is not updated + trashpoints which user creats aren't added to team statistics + user can join any other team without leaving current one and teams are just overwritten in his profile http://take.ms/uu8zU

Expected result: user becomes team member and member counter increased by 1

@lynxlynxlynx
Copy link
Collaborator

Partly a duplicate of #287
it's unclear if the fixes were moved over, they don't seem to be merged to master yet.

@Dasha1990
Copy link
Collaborator Author

got it. as I understand now this works fine on the prod so we would need to find and add this functionality to server side

@Dasha1990
Copy link
Collaborator Author

now its blocking us from checking full flow, cause we can't correctly join team, see members list, see team stats

@lynxlynxlynx
Copy link
Collaborator

Surely that's a different or higher level bug?

@Dasha1990
Copy link
Collaborator Author

I guess this issue with join also caused all other stuff and server logic will work when users will join team correctly (as I understand it is only backend part and apps can't really affect it)

aleksandr-wemakesoftware added a commit to aleksandr-wemakesoftware/World-Cleanup-Day that referenced this issue Jun 29, 2018
SlavaPanevskiy pushed a commit that referenced this issue Jul 2, 2018
* WIP teams

* team trashpoints list and pr fixes

* more fixes from review

* team in profile and refetching team data after joining

* team icon in profile

* #300, #301 bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants