Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CNAME/DNAME logic #1065

Merged
merged 2 commits into from Nov 3, 2015
Merged

Remove CNAME/DNAME logic #1065

merged 2 commits into from Nov 3, 2015

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Oct 31, 2015

Fixes #1048

@jsha jsha added the r? label Oct 31, 2015
@jsha jsha added this to the General Availability milestone Oct 31, 2015
@kuba kuba mentioned this pull request Nov 2, 2015
Closed
@rolandshoemaker rolandshoemaker mentioned this pull request Nov 2, 2015
Closed
jmhodges
jmhodges reviewed Nov 2, 2015
View reviewed changes
va/validation-authority_test.go
"cname-servfail.com",
"cname2servfail.com",
"dname-servfail.com",
"cname-and-dname.com",
"servfail.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one record in this slice now. Does it make sense to have it still?

Copy link
Contributor Author

@jsha jsha Nov 2, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmhodges
Copy link
Contributor

jmhodges commented Nov 2, 2015

LGTM

@jmhodges
Copy link
Contributor

jmhodges commented Nov 2, 2015

(Test failures)

@jsha
Copy link
Contributor Author

jsha commented Nov 3, 2015

Tests work now.

rolandshoemaker added a commit that referenced this pull request Nov 3, 2015
@rolandshoemaker
Merge pull request #1065 from letsencrypt/caa-fix
3ee0859 
Remove CNAME/DNAME logic
@rolandshoemaker rolandshoemaker merged commit 3ee0859 into master Nov 3, 2015
@domenkozar
Copy link

Are we waiting for this to be deployed the server?

@jsha
Copy link
Contributor Author

jsha commented Nov 5, 2015

That's correct.

@jsha jsha deleted the caa-fix branch November 5, 2015 18:48
@domenkozar
Copy link

Cool, I'll be happy if someone pings this issue once that's done (or let me know what I can track to get that notification)

@jsha
Copy link
Contributor Author

jsha commented Nov 5, 2015

I'd recommend checking https://acme-v01.api.letsencrypt.org/build periodically so you can see when the build is updated to a newer timestamp (or to a git revision that includes this change).

@domenkozar
Copy link

thanks!

@sachaz
Copy link

sachaz commented Nov 7, 2015

up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
r=jmhodges r=rolandshoemaker
Projects
None yet
Milestone
General Availability
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsha @jmhodges @domenkozar @sachaz @rolandshoemaker