Add stagger to CT log submissions. #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows each log a chance to respond before we move onto the next, spreading our load more evenly across the logs in a log group.
cpu
suggested changes
Jul 6, 2018
There was a problem hiding this comment.
One small nit to request fixed. This is a small PR but I would feel better if there was a unit test as well if that's doable within the constraints at hand. It seems like setting a really high Stagger for one of two logs in a test configuration and then asserting that only the first log had a submission before timing out a shorter context would be sufficient.
ctpolicy/ctpolicy.go
Outdated
| @@ -79,7 +85,15 @@ func (ctp *CTPolicy) race(ctx context.Context, cert core.CertDER, group cmd.CTGr | |||
| // so we maximize the distribution of logs we get SCTs from. | |||
| for _, i := range rand.Perm(len(group.Logs)) { | |||
| l := group.Logs[i] | |||
| go func(l cmd.LogDescription) { | |||
| go func(i int, l cmd.LogDescription) { | |||
| // Each submission waits 500ms longer than the previous one, to give the | |||
There was a problem hiding this comment.
I think the 500ms part of this comment isn't necessarily accurate since group.Stagger.Duration is configurable.
cpu
approved these changes
Jul 6, 2018
cpu
suggested changes
Jul 6, 2018
ctpolicy/ctpolicy_test.go
Outdated
| ctp := New(countingPub, []cmd.CTGroup{ | ||
| { | ||
| Name: "a", | ||
| Stagger: cmd.ConfigDuration{500 * time.Millisecond}, |
There was a problem hiding this comment.
Go vet is flagging this in CI:
# github.com/letsencrypt/boulder/ctpolicy
ctpolicy/ctpolicy_test.go:186: github.com/letsencrypt/boulder/cmd.ConfigDuration composite literal uses unkeyed fields
cpu
approved these changes
Jul 6, 2018
|
Merging with one review based on dev availability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows each log a chance to respond before we move onto the next,
spreading our load more evenly across the logs in a log group.