Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features: Deprecate CertCheckerRequiresCorrespondence #7542

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Jun 12, 2024

Also, update the comment in features.go to clarify when features can be removed.

Reviewers: Using the "Hide whitespace" option under diff viewing options (gear icon) is useful for this one.

@jsha jsha requested a review from a team as a code owner June 12, 2024 19:38
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge main to fix the test failure.

@beautifulentropy beautifulentropy requested review from a team, aarongable and pgporada and removed request for a team June 13, 2024 16:19
@beautifulentropy beautifulentropy changed the title deprecate CertCheckerRequiresCorrespondence features: Deprecate CertCheckerRequiresCorrespondence Jun 17, 2024
@beautifulentropy beautifulentropy merged commit 1ece848 into main Jun 17, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the deprecate-correspondence branch June 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants