Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set trailingComma to es5 #36

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Set trailingComma to es5 #36

merged 2 commits into from
Jun 19, 2023

Conversation

ramonakira
Copy link
Member

I think this improved readability quite a bit. See also issue #20

@jaap3
Copy link
Member

jaap3 commented Jun 12, 2023

Seems like a reasonable change. Since it's also the default, we could just omit this bit of the configuration instead of explicitly setting it.

@ramonakira
Copy link
Member Author

I removed it!

@ramonakira ramonakira merged commit d68bbaa into main Jun 19, 2023
@ramonakira ramonakira deleted the ramonakira-patch-1 branch June 19, 2023 09:02
@ramonakira ramonakira mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaap3 jaap3 jaap3 approved these changes

@dbunskoek dbunskoek Awaiting requested review from dbunskoek dbunskoek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonakira @jaap3