Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create testing helpers for grids #83

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Conversation

bchopson
Copy link
Member

  • Add GridBase as grid test base class
  • Add PGCompilerMixin
  • Add MSSQLCompilerMixin
  • Example tests for the dialect mixins in test_testing (requires
    changing the database backend)

Fixes #68

@bchopson bchopson force-pushed the 68-testing-helpers branch 2 times, most recently from d7fc3d5 to 0f5cb44 Compare November 13, 2019 20:37
@bchopson bchopson self-assigned this Nov 13, 2019
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #83 into master will decrease coverage by 0.37%.
The diff coverage is 76.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   90.49%   90.11%   -0.38%     
==========================================
  Files          33       33              
  Lines        5377     5545     +168     
  Branches      437      458      +21     
==========================================
+ Hits         4866     4997     +131     
- Misses        437      467      +30     
- Partials       74       81       +7     
Impacted Files Coverage Δ
webgrid/tests/helpers.py 83.90% <63.63%> (-3.11%) ⬇️
webgrid/testing.py 73.23% <67.82%> (-23.06%) ⬇️
webgrid/tests/test_testing.py 100.00% <100.00%> (ø)
webgrid_ta/grids.py 98.95% <100.00%> (+0.13%) ⬆️
webgrid/renderers.py 93.36% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ce644...327760e. Read the comment docs.

@bchopson bchopson assigned guruofgentoo and unassigned bchopson Nov 13, 2019
@bchopson bchopson force-pushed the 68-testing-helpers branch 2 times, most recently from b4647f6 to c1fe61f Compare September 21, 2020 13:14
bchopson and others added 2 commits October 9, 2020 10:34
- Add GridBase as grid test base class
- Add PGCompilerMixin
- Add MSSQLCompilerMixin
- Example tests for the dialect mixins in test_testing (requires
  changing the database backend)

Refs #68
- keep dialect-specific treatment of mssql for unicode string matching
- add tests to verify "expect" method assertions
refs #68
@guruofgentoo guruofgentoo merged commit 3d5867f into master Oct 9, 2020
@guruofgentoo guruofgentoo deleted the 68-testing-helpers branch October 9, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helpers for testing grids
2 participants