Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies #6

Merged
merged 4 commits into from
Jan 2, 2014
Merged

updated dependencies #6

merged 4 commits into from
Jan 2, 2014

Conversation

elf-pavlik
Copy link
Member

should I also rename join() and joinStream() to search() and searchStream() ?

@mcollina
Copy link
Collaborator

Go ahead and merge, you have the commit bit!

@elf-pavlik
Copy link
Member Author

@mcollina once I know what exactly I can s/join/search/ then I'll do it and merge. afterwards you can release newer version of this one as well 😄

@mcollina
Copy link
Collaborator

please, do s/join/search :)

@elf-pavlik
Copy link
Member Author

renaming done!

how do we go about deprecating augmented db.join() replaced by augmented db.search()?
could we maybe keep everything N3 related under db.n3 -> db.n3.search()?
also i still need to take a closer look how you do this, especially thinking of using multiple extensions N3 + JSONLD + ...

@mcollina
Copy link
Collaborator

The renaming is coded in a way such that if you just augment db.search it should work with db.join, but check ;).

I'm open to namespacing, too. I think it's better and it will avoid us problems later, so go for it!

@elf-pavlik
Copy link
Member Author

changing db.search() to db.join() in search_spec.js fails!
changing db.searchStream() to db.joinStream() in searchStream_spec.js fails!

still both give nice deprecation warnings when used 😄

I'll look at keeping it namespaced...

BTW I should have created feature branch for this one here... first though that will just bump few dependencies 😕

@elf-pavlik
Copy link
Member Author

i think about merging those few changes here and after that creating v0.4.0-wip branch to work on changing the way we do N3 specific searches?

@mcollina
Copy link
Collaborator

mcollina commented Jan 2, 2014

I'm ok with this. If you want to 'kill' the search feature for
materialiazed N3, go for it. We'll reintroduce it back when we need it.

elf-pavlik pushed a commit that referenced this pull request Jan 2, 2014
updated dependencies + s/join/search/
@elf-pavlik elf-pavlik merged commit 553cd3f into levelgraph:master Jan 2, 2014
@mcollina
Copy link
Collaborator

mcollina commented Jan 2, 2014

Is this ready for release? ;)

@elf-pavlik
Copy link
Member Author

after #7 which looks like it will break current API...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants