Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fee setter #22

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Add fee setter #22

merged 4 commits into from
Oct 13, 2020

Conversation

AugustoL
Copy link

@AugustoL AugustoL commented Oct 11, 2020 •
edited
Loading

  • Add DXswapFeeSetter contract that will handle the fees over DXswapFactory from an owner address that will be dxdao, in addition it will allow pairs to be "owned" by another address too, giving the possibility to a "pair owner" to change the swap fee of it.
  • Add DXswapDeployer and DXswapFeeSetter to the fixtures in the tests, to test the factory and pairs following the same deployment process it will be used in mainnet.

@jpkcambridge jpkcambridge mentioned this pull request Oct 13, 2020
Closed
@nicoelzer nicoelzer self-requested a review October 13, 2020 14:56
@jpkcambridge jpkcambridge self-requested a review October 13, 2020 20:36
@AugustoL AugustoL merged commit 8c1716d into develop Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkcambridge jpkcambridge jpkcambridge approved these changes

@nicoelzer nicoelzer nicoelzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AugustoL @jpkcambridge @nicoelzer