dapp: Refactor to use smart meter API calls + bring back Eve and draw energy consumption graph #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this yet |
fangyi-zhou
requested changes
Nov 17, 2017
| const unitPrice = await contract.unitPrice(); | ||
| contracts.push({contractAddr, unitPrice, offeredAmount}) | ||
| contracts.push({contractAddr: contractAddr, unitPrice: unitPrice, offeredAmount: offeredAmount}) |
There was a problem hiding this comment.
So that I can access the fields by their name?
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh right, I forgot about those. Will change
This was referenced Nov 17, 2017
Closed
|
Please rebase master and cherry pick commits related to this PR |
This was referenced Nov 23, 2017
fangyi-zhou
reviewed
Nov 23, 2017
dapp/src/client/scripts/app.jsx
Outdated
| async getAvailableContracts() { | ||
| fetch('http://localhost:3000/contract/available_contracts') | ||
| .then(response => response.json()) | ||
| .then(contracts => contracts.filter((c) => c.offeredAmount > 0)) |
There was a problem hiding this comment.
You shouldn't need to do that i suppose
fangyi-zhou
reviewed
Nov 23, 2017
dapp/src/client/scripts/app.jsx
Outdated
| async getSellerContracts() { | ||
| fetch('http://localhost:3000/contract/my_seller_contracts') | ||
| .then(response => response.json()) | ||
| .then(contracts => contracts.filter((c) => c.offeredAmount > 0)) |
|
Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The energy consumption graph is now drawn, using real data fetched from the smart meter Eve API.