Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable changing leading whitespace by default #28

Merged
merged 1 commit into from
Jan 11, 2017
Merged

disable changing leading whitespace by default #28

merged 1 commit into from
Jan 11, 2017

Conversation

ian-kelling
Copy link
Contributor

This fixes #25.

This should be merged instead of pull request #27. It's the same except condition on a config option instead of smart tabs (and use when instead of if).

@npostavs
Copy link

npostavs commented Jan 9, 2017

Perhaps also incorporate the check from on smart-tabs-mode from #27? Though it should be (bound-and-true-p smart-tabs-mode) to avoid error if smart-tabs-mode is not loaded.

@ian-kelling
Copy link
Contributor Author

Perhaps also incorporate the check from on smart-tabs-mode from #27? Though it should be (bound-and-true-p smart-tabs-mode) to avoid error if smart-tabs-mode is not loaded

I buy that. The pull request has been updated.


If `indent-tabs-mode' is non-nil, call `tabify', else call
`untabify'. Do neither if `smart-tabs-mode' is enabled for this
buffer. This is off by default because it's unwanted if you
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be on by default. Not sure whether you want to change the doc or the code...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Was testing and forgot to change it back. I've updated it to be off.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the default value derive from smart-tabs-mode?

Copy link
Contributor Author

@ian-kelling ian-kelling Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the default value derive from smart-tabs-mode?

No. smart-tabs-mode is only enabled in about 6 specific major modes usually, and even if it weren't, I think that would be subject to which package got loaded first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please don't look at indent-tabs-mode
3 participants