Sourcery Starbot ⭐ refactored lewoudar/scalpel #19

SourceryAI · 2023-05-20T06:19:55Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/scalpel master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2023-05-20T06:19:57Z

scalpel/__version__.py

-    return tuple([int(i) for i in __version__.split('.')])
+    return tuple(int(i) for i in __version__.split('.'))


Function version_info refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

SourceryAI · 2023-05-20T06:19:57Z

scalpel/any_io/selenium_spider.py

-        error_message = ''
-        if ur.scheme == 'file':
-            error_message = f'unable to open file {url}'
-
+        error_message = f'unable to open file {url}' if ur.scheme == 'file' else ''


Function SeleniumSpider._handle_url refactored with the following changes:

Move setting of default value for variable into else branch (introduce-default-else)

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2023-05-20T06:19:58Z

scalpel/core/config.py

-    if filename in ['chromedriver', 'geckodriver']:
+    if filename in {'chromedriver', 'geckodriver'}:


Function check_driver_presence refactored with the following changes:

Use set when checking membership of a collection of literals (collection-into-set)

SourceryAI · 2023-05-20T06:19:58Z

scalpel/core/config.py

-    callables = []
-    for str_callable in str_callable_list:
-        callables.append(get_callable_from_string(str_callable))
-
+    callables = [
+        get_callable_from_string(str_callable)
+        for str_callable in str_callable_list
+    ]


Function callable_list_converter refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

SourceryAI · 2023-05-20T06:19:58Z

scalpel/core/config.py

-    if isinstance(value, Path):
-        return str(value.absolute())
-    return str(value)
+    return str(value.absolute()) if isinstance(value, Path) else str(value)


Function str_converter refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2023-05-20T06:20:00Z

tests/green/test_files.py

-        assert [content] == [item for item in read_mp(mp_file)]
+        assert [content] == list(read_mp(mp_file))


Function TestWriteMp.test_should_write_bytes_when_giving_content_in_write_mode_without_custom_encoder refactored with the following changes:

Replace identity comprehension with call to collection constructor (identity-comprehension)

SourceryAI · 2023-05-20T06:20:00Z

tests/green/test_files.py

-        assert [content] == [item for item in read_mp(mp_file, decoder=decode_datetime)]
+        assert [content] == list(read_mp(mp_file, decoder=decode_datetime))


Function TestWriteMp.test_should_write_bytes_when_giving_content_in_write_mode_with_custom_encoder refactored with the following changes:

Replace identity comprehension with call to collection constructor (identity-comprehension)

SourceryAI · 2023-05-20T06:20:01Z

tests/green/test_files.py

-        assert content == [item for item in read_mp(mp_file)]
+        assert content == list(read_mp(mp_file))


Function TestWriteMp.test_should_write_bytes_when_giving_content_in_append_mode_without_custom_encoder refactored with the following changes:

Replace identity comprehension with call to collection constructor (identity-comprehension)

SourceryAI · 2023-05-20T06:20:01Z

tests/green/test_files.py

-        assert content == [item for item in read_mp(mp_file, decoder=decode_datetime)]
+        assert content == list(read_mp(mp_file, decoder=decode_datetime))


Function TestWriteMp.test_should_write_bytes_when_giving_content_in_append_mode_with_custom_encoder refactored with the following changes:

Replace identity comprehension with call to collection constructor (identity-comprehension)

SourceryAI · 2023-05-20T06:20:01Z

tests/green/test_static_spider.py

-        assert [fruit_1, fruit_2] == [item for item in read_mp(f'{backup.resolve()}')]
+        assert [fruit_1, fruit_2] == list(read_mp(f'{backup.resolve()}'))


Function TestStaticSpider.test_should_save_content_to_backup_file refactored with the following changes:

Replace identity comprehension with call to collection constructor (identity-comprehension)

SourceryAI · 2023-05-20T06:20:05Z

tests/green/utils/test_io.py

-        assert [] == [line for line in async_file]
+        assert [] == list(async_file)


Function TestAsyncFile.test_iter_method_is_implemented refactored with the following changes:

Replace identity comprehension with call to collection constructor (identity-comprehension)

SourceryAI · 2023-05-20T06:20:05Z

tests/green/utils/test_io.py

-            for line in f:
-                result.append(line)
-
+            result.extend(iter(f))


Function TestOpenFile.test_open_file_works_as_expected refactored with the following changes:

Replace a for append loop with list extend (for-append-to-extend)

Simplify generator expression (simplify-generator)

'Refactored by Sourcery'

01a725e

SourceryAI commented May 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery Starbot ⭐ refactored lewoudar/scalpel #19

Sourcery Starbot ⭐ refactored lewoudar/scalpel #19

SourceryAI commented May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

SourceryAI May 20, 2023

		return tuple([int(i) for i in __version__.split('.')])
		return tuple(int(i) for i in __version__.split('.'))

		if filename in ['chromedriver', 'geckodriver']:
		if filename in {'chromedriver', 'geckodriver'}:

		assert [content] == [item for item in read_mp(mp_file)]
		assert [content] == list(read_mp(mp_file))

		assert content == [item for item in read_mp(mp_file)]
		assert content == list(read_mp(mp_file))

		assert content == [item for item in read_mp(mp_file, decoder=decode_datetime)]
		assert content == list(read_mp(mp_file, decoder=decode_datetime))

		assert [fruit_1, fruit_2] == [item for item in read_mp(f'{backup.resolve()}')]
		assert [fruit_1, fruit_2] == list(read_mp(f'{backup.resolve()}'))

		assert [] == [line for line in async_file]
		assert [] == list(async_file)

Sourcery Starbot ⭐ refactored lewoudar/scalpel #19

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored lewoudar/scalpel #19

Conversation

SourceryAI commented May 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment