Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake install path #126

Closed
vallahaye opened this issue Jan 8, 2018 · 4 comments
Closed

CMake install path #126

vallahaye opened this issue Jan 8, 2018 · 4 comments

Comments

@vallahaye
Copy link
Contributor

vallahaye commented Jan 8, 2018

install(DIRECTORY "${PROJECT_DIR_API_HEADER}" DESTINATION "include" FILES_MATCHING PATTERN "*.h")

This line in your CMakeLists.txt makes CMake install header files in /usr/local/include/include/ instead of /usr/local/include. Consider changing it to :

file(GLOB PROJECT_HEADER_DIRS "${PROJECT_DIR_API_HEADER}/*")
foreach(ITEM ${PROJECT_HEADER_DIRS})                                                                                                                                                
    if(IS_DIRECTORY "${ITEM}")
        install(DIRECTORY "${ITEM}" DESTINATION "include" FILES_MATCHING PATTERN "*.h")
    endif()
endforeach()

This installs all subdirectories contained in include one by one.
Also are you planning on releasing version 4.0.3 (or 4.1) with all the recent changes ? I'm really looking forward to this so I can rely on a version of your library which supports CMake builds.

Thank you for the time you spend on this and your amazing work. I'm using myhtml in one of my project and it rocks !

@lexborisov
Copy link
Owner

Hi!

In fact, it's enough just to put the symbol / after ${PROJECT_DIR_API_HEADER} like that:

install(DIRECTORY "${PROJECT_DIR_API_HEADER}/" DESTINATION "include" FILES_MATCHING PATTERN "*.h")

Your option seems to me more correct, I applied it.
Thank you for submitting this bug, and thanks for using myhtml.

@vallahaye
Copy link
Contributor Author

Not sure if it's quiet the same tho as your option would cause CMake to change the output directory permissions (I'm talking about the /usr/local/include directory) which is not what you want. Mine does not. Thank you very for your reactivity !

PS: What about my question regarding a potential release date ?

@lexborisov
Copy link
Owner

Last Release 4.0.4 12 hour ago.

@vallahaye
Copy link
Contributor Author

Thank you very much ! I'm closing the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants