Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check consonant clusters #274

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Check consonant clusters #274

merged 4 commits into from
Apr 30, 2024

Conversation

chrzyki
Copy link
Contributor

@chrzyki chrzyki commented Apr 24, 2024

Command as proposed and implemented by @LinguList for checking (potentially) problematic consonant clusters.

@FredericBlum
Copy link
Contributor

I have two ideas for potential additions:

  • Add a summary per dataset, so we can identify the ˈworstˈ cases that need immediate attention
  • Add an argument for the length of clusters to be checked. 3 could be the default, but maybe we want ot check for 4 or 5 first, to identify the most problematic cases?

Also, I am thinking that maybe the Segments would be a more relevant output than the (unstandardized) form. It seems difficult at some points to identify the problematic part in the forms. Maybe we could output both? What do you think?

Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the proposal.

@chrzyki chrzyki merged commit cbbaa1f into master Apr 30, 2024
4 checks passed
@chrzyki chrzyki deleted the consonant-clusters branch April 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants