-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release #9
Conversation
This PR does not address #8 right? I think we have to take care of this, since this lead to many doubled entries. |
No, this will be a separate PR. |
Tests are allowed to fail for now. 47827ed and subsequent are a draft to use the online supplement as discussed in #8 to also fix lexibank/lexibank-analysed#49. Note that this is a very quick first draft for using the other data source and I fully expect cognates etc. not to be working 100% correctly for now. Things I need to do:
|
Apologies, I just continued working in this PR! |
After a first spot checking everything looks good with using the online supplement rather than the previous raw TSV. The cognate sets also seem correct to me. @LinguList, this would close #8 (but I'm still going to do some more checks and clean up the XLSX->CSV process). It fixes the issue with the cognates occuring multiple times and leading to doublets (triplets, etc.) in the lexeme list and Lexibank. Also, the online supplement version of the data contains more language (varieties) than the previous raw data file (
Should those be included as well or were they excluded for a reason? (not an expert on the languages/studies so there might be a reason I'm not seeing here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. In my opinion, the major work is done for now. Very cool, that you used the official data now, @chrzyki. If we realize that there are any different errors in the future, we can look into those in subsequent versions. For now, I'd say that this is good enough for lexibank 2.0.
Thank you very much for checking! I'll prepare the updated release for Lexibank 2.0. |
No description provided.