This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
Remove deprecation notice in PHP 8.1 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `TreeBuilder` return type to `Lexik\Bundle\FormFilterBundle\DependencyInjection\Configuration::getConfigTreeBuilder()` to remove a deprecation notice triggered by the missing return type in PHP 8.1. That does not conflict with older PHP versions, since at least PHP 7.1 is required in composer.json for the bundle. Also tidies up the "BC layer for symfony/config 4.1 and older" from that method as in composer.json at least Symfony 4.4 is required for the bundle and the BC layer is not needed anymore.
|
Failing tests for PHP 8.1/Symfony 6.1.*@dev seems to be not related to my changes:
|
|
Hey, any news on this? Would be nice to get that fixed, from my point of view my proposed changes don't have any side effects. |
|
In the interest of keeping this PR active, I'm keen to see this deprecation fixed also 👍 |
|
@Spike31 is there anything missing here? Can I provide something? |
|
Thx @spackmat for the delay, tag created |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
TreeBuilderreturn type toLexik\Bundle\FormFilterBundle\DependencyInjection\Configuration::getConfigTreeBuilder()to remove a deprecation notice triggered by the missing return type in PHP 8.1. That does not conflict with older PHP versions, since at least PHP 7.1 is required in composer.json for the bundle.Also tidies up the "BC layer for symfony/config 4.1 and older" from that method as in composer.json at least Symfony 4.4 is required for the bundle and the BC layer is not needed anymore.